Refuse to promote a dev image whose version differs from the tag
release.yml never reads the repository, so a tag could be published for an image reporting a different version, or for a stale dev image when the main build had not landed yet. Read package.json from the dev image before promotion and fail on mismatch.
This commit is contained in:
1 file changed
+12
@@ -42,6 +42,18 @@ jobs:
|
|||||||
fi
|
fi
|
||||||
echo "Promoting ${IMAGE}:dev -> ${IMAGE}:${TAG}"
|
echo "Promoting ${IMAGE}:dev -> ${IMAGE}:${TAG}"
|
||||||
|
|
||||||
|
- name: Verify dev image version
|
||||||
|
run: |
|
||||||
|
set -euo pipefail
|
||||||
|
VERSION="${TAG#v}"
|
||||||
|
IMAGE_VERSION="$(docker run --rm --network none --entrypoint cat "${SOURCE_REF}" /app/package.json | jq -r '.version')"
|
||||||
|
if [ "${IMAGE_VERSION}" != "${VERSION}" ]; then
|
||||||
|
echo "Refusing to release ${TAG}: the dev image reports ${IMAGE_VERSION}." >&2
|
||||||
|
echo "Wait for the main build to publish a fresh dev image, or set package.json to ${VERSION}." >&2
|
||||||
|
exit 1
|
||||||
|
fi
|
||||||
|
echo "Dev image reports ${IMAGE_VERSION}; promoting to ${TAG}."
|
||||||
|
|
||||||
- name: Promote image
|
- name: Promote image
|
||||||
run: |
|
run: |
|
||||||
set -euo pipefail
|
set -euo pipefail
|
||||||
|
|||||||
Reference in new issue
Block a user