From 3bb188415124440cf96a7c3e39b5692b52295192 Mon Sep 17 00:00:00 2001 From: Marco D'Aleo Date: Fri, 13 Nov 2026 07:45:40 +0000 Subject: [PATCH] Refuse to promote a dev image whose version differs from the tag release.yml never reads the repository, so a tag could be published for an image reporting a different version, or for a stale dev image when the main build had not landed yet. Read package.json from the dev image before promotion and fail on mismatch. --- .gitea/workflows/release.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.gitea/workflows/release.yml b/.gitea/workflows/release.yml index e8b66f4..4cb4252 100644 --- a/.gitea/workflows/release.yml +++ b/.gitea/workflows/release.yml @@ -42,6 +42,18 @@ jobs: fi echo "Promoting ${IMAGE}:dev -> ${IMAGE}:${TAG}" + - name: Verify dev image version + run: | + set -euo pipefail + VERSION="${TAG#v}" + IMAGE_VERSION="$(docker run --rm --network none --entrypoint cat "${SOURCE_REF}" /app/package.json | jq -r '.version')" + if [ "${IMAGE_VERSION}" != "${VERSION}" ]; then + echo "Refusing to release ${TAG}: the dev image reports ${IMAGE_VERSION}." >&2 + echo "Wait for the main build to publish a fresh dev image, or set package.json to ${VERSION}." >&2 + exit 1 + fi + echo "Dev image reports ${IMAGE_VERSION}; promoting to ${TAG}." + - name: Promote image run: | set -euo pipefail