guardutils/mirro
1
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 5 Wiki Activity

Pass 'unknown' args to the backend EDITOR #2

Closed
mig5 wants to merge 1 commits from mig/pass-extra-args-to-editor into main
pull from: mig/pass-extra-args-to-editor
merge into: guardutils:main
Conversation 2 Commits 1 Files Changed 1 +3 -2
mig5 commented 2025-11-12 22:15:24 +00:00 (Migrated from github.com)
Copy Link

Fixes #1

I found a nice way. argparse's parse_known_args creates a separate tuple for unrecognised args. We can then leverage this to pass them to the backend EDITOR (on the assumption that any unknown args might be known by the backend EDITOR tool).

To test: run this version with EDITOR=vim mirro somefile +3 and check that it jumps to line 3 of the file somefile.

Fixes #1 I found a nice way. argparse's [`parse_known_args`](https://docs.python.org/3/library/argparse.html#argparse.ArgumentParser.parse_known_args) creates a separate tuple for unrecognised args. We can then leverage this to pass them to the backend EDITOR (on the assumption that any unknown args *might* be known by the backend EDITOR tool). To test: run this version with `EDITOR=vim mirro somefile +3` and check that it jumps to line 3 of the file `somefile`.
mdaleo404 (Migrated from github.com) reviewed 2025-11-12 22:15:24 +00:00
mdaleo404 commented 2025-11-13 15:32:46 +00:00 (Migrated from github.com)
Copy Link

Thank you for your PR 😄
Unfortunatelly this will only work when +3 is expected after somefile (e.g. using Vim).
It won't work for Nano as the expected command should be EDITOR=nano mirro +3 somefile

I'm closing this PR.

Thank you for your PR :smile: Unfortunatelly this will only work when `+3` is expected after `somefile` (e.g. using Vim). It won't work for Nano as the expected command should be `EDITOR=nano mirro +3 somefile` I'm closing this PR.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
mdaleo404
Labels
Clear labels
bug
Something isn't working
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
mdaleo404
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: guardutils/mirro#2
Delete Branch "mig/pass-extra-args-to-editor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?